Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compaction metrics #2560

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Oct 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add metrics for compaction.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2560 (450fe0a) into develop (8a5ef82) will decrease coverage by 0.41%.
Report is 1 commits behind head on develop.
The diff coverage is 83.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2560      +/-   ##
===========================================
- Coverage    85.41%   85.01%   -0.41%     
===========================================
  Files          737      737              
  Lines       118001   118021      +20     
===========================================
- Hits        100794   100336     -458     
- Misses       17207    17685     +478     

@v0y4g3r v0y4g3r requested review from evenyag and waynexia October 10, 2023 06:02
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito2/src/request.rs Outdated Show resolved Hide resolved
@evenyag evenyag enabled auto-merge October 10, 2023 07:04
@evenyag evenyag added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 10, 2023
@evenyag evenyag enabled auto-merge October 10, 2023 07:38
@evenyag evenyag added this pull request to the merge queue Oct 10, 2023
Merged via the queue into GreptimeTeam:develop with commit 6b39f59 Oct 10, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: add compaction metrics

* feat: add compaction request total count

* fix: CR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants