Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: human_time mismatch #2558

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Oct 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

datetime is millisecond precision now(before is second)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2469

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2558 (d9dab4b) into develop (8cc862f) will decrease coverage by 0.36%.
Report is 10 commits behind head on develop.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2558      +/-   ##
===========================================
- Coverage    85.36%   85.00%   -0.36%     
===========================================
  Files          737      737              
  Lines       117542   118001     +459     
===========================================
- Hits        100334   100304      -30     
- Misses       17208    17697     +489     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@WenyXu @fengjiachun PTAL

@evenyag evenyag enabled auto-merge October 10, 2023 07:12
@evenyag evenyag added this pull request to the merge queue Oct 10, 2023
Merged via the queue into GreptimeTeam:develop with commit 4fe7e16 Oct 10, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: human_time mismatch.

* fix: add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants