-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add new action 'release-cn-artifacts' #2554
Merged
killme2008
merged 2 commits into
GreptimeTeam:develop
from
zyy17:refactor/release-artifacts-to-cn-region
Oct 11, 2023
Merged
refactor: add new action 'release-cn-artifacts' #2554
killme2008
merged 2 commits into
GreptimeTeam:develop
from
zyy17:refactor/release-artifacts-to-cn-region
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy17
force-pushed
the
refactor/release-artifacts-to-cn-region
branch
2 times, most recently
from
October 10, 2023 02:11
83f22a6
to
fa60533
Compare
This PR can be reviewed only after the official release of v0.4.0 to avoid potential failure of the v0.4.0 release due to insufficient testing. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2554 +/- ##
==========================================
Coverage ? 84.98%
==========================================
Files ? 737
Lines ? 118020
Branches ? 0
==========================================
Hits ? 100304
Misses ? 17716
Partials ? 0 |
daviderli614
approved these changes
Oct 10, 2023
zyy17
force-pushed
the
refactor/release-artifacts-to-cn-region
branch
from
October 11, 2023 03:14
909be24
to
99884e8
Compare
killme2008
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
sunng87
approved these changes
Oct 11, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: add new action 'release-cn-artifacts' * refactor: refine naming: 'release-artifacts' -> 'publish-github-release' Signed-off-by: zyy17 <[email protected]> --------- Signed-off-by: zyy17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add new action 'release-cn-artifacts' to make the action of releasing artifacts to cn region idempotent(always can retry);
Refine naming:
release-artifacts
->publish-github-release
;Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)