Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add new action 'release-cn-artifacts' #2554

Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add new action 'release-cn-artifacts' to make the action of releasing artifacts to cn region idempotent(always can retry);

  2. Refine naming: release-artifacts -> publish-github-release;

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17 zyy17 force-pushed the refactor/release-artifacts-to-cn-region branch 2 times, most recently from 83f22a6 to fa60533 Compare October 10, 2023 02:11
@zyy17 zyy17 marked this pull request as ready for review October 10, 2023 02:16
@zyy17
Copy link
Collaborator Author

zyy17 commented Oct 10, 2023

This PR can be reviewed only after the official release of v0.4.0 to avoid potential failure of the v0.4.0 release due to insufficient testing.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@9284bb7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2554   +/-   ##
==========================================
  Coverage           ?   84.98%           
==========================================
  Files              ?      737           
  Lines              ?   118020           
  Branches           ?        0           
==========================================
  Hits               ?   100304           
  Misses             ?    17716           
  Partials           ?        0           

@zyy17 zyy17 force-pushed the refactor/release-artifacts-to-cn-region branch from 909be24 to 99884e8 Compare October 11, 2023 03:14
@zyy17 zyy17 requested a review from sunng87 October 11, 2023 03:34
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@killme2008 killme2008 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into GreptimeTeam:develop with commit d7aeb36 Oct 11, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: add new action 'release-cn-artifacts'

* refactor: refine naming: 'release-artifacts' -> 'publish-github-release'

Signed-off-by: zyy17 <[email protected]>

---------

Signed-off-by: zyy17 <[email protected]>
@zyy17 zyy17 deleted the refactor/release-artifacts-to-cn-region branch October 20, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants