Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics for region server #2552

Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add metrics for region_server.handle_request

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengjiachun fengjiachun requested review from waynexia and WenyXu October 9, 2023 12:00
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2552 (40b83f4) into develop (d68dd1f) will decrease coverage by 0.39%.
Report is 9 commits behind head on develop.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2552      +/-   ##
===========================================
- Coverage    85.39%   85.00%   -0.39%     
===========================================
  Files          737      737              
  Lines       117734   118019     +285     
===========================================
- Hits        100538   100322     -216     
- Misses       17196    17697     +501     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

src/datanode/src/metrics.rs Show resolved Hide resolved
@fengjiachun
Copy link
Collaborator Author

@killme2008 PTAL

@fengjiachun fengjiachun enabled auto-merge October 10, 2023 07:30
@fengjiachun fengjiachun added this pull request to the merge queue Oct 10, 2023
Merged via the queue into GreptimeTeam:develop with commit ae95f23 Oct 10, 2023
@fengjiachun fengjiachun deleted the feat/metrics-region-server branch October 10, 2023 07:50
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: add metircs for region server

* fix: add comment and remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants