Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mito): change default batch size/row group size #2550

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Change default batch size and row group size to 1024 and 100 * 1024.

Arrow aligns its buffer to a multiple of 64 so our old default batch size (1000) wastes some slots.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review October 9, 2023 09:30
@evenyag evenyag requested review from v0y4g3r and waynexia October 9, 2023 09:33
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2550 (b3e4dfa) into develop (8cc862f) will decrease coverage by 0.37%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2550      +/-   ##
===========================================
- Coverage    85.36%   84.99%   -0.37%     
===========================================
  Files          737      737              
  Lines       117542   117545       +3     
===========================================
- Hits        100334    99904     -430     
- Misses       17208    17641     +433     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Oct 9, 2023
Merged via the queue into GreptimeTeam:develop with commit 81aa7a4 Oct 9, 2023
21 of 22 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants