-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide internal error and unknown error message from end user #2544
Conversation
It seems we are using some internal 1003 for invalid argument or other user errors. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2544 +/- ##
===========================================
- Coverage 85.16% 84.76% -0.40%
===========================================
Files 738 738
Lines 118955 118321 -634
===========================================
- Hits 101304 100292 -1012
- Misses 17651 18029 +378 |
@evenyag @waynexia @shuiyisong PTAL There is a chance I haven't covered all errors that should be excluded from |
c8dcba0
to
d110014
Compare
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch masks error message of any internal error and unknown error from end user, to prevent leak of deployment and other credential information.
Checklist
Refer to a related PR or issue link (optional)