feat: dist plan optimize part 2 #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
approved these changes
Oct 8, 2023
Signed-off-by: Ruihang Xia <[email protected]>
killme2008
reviewed
Oct 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2543 +/- ##
===========================================
- Coverage 85.33% 84.98% -0.35%
===========================================
Files 734 734
Lines 117313 117344 +31
===========================================
- Hits 100106 99729 -377
- Misses 17207 17615 +408 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* allow udf and scalar fn Signed-off-by: Ruihang Xia <[email protected]> * put CountWildcardRule before dist planner Signed-off-by: Ruihang Xia <[email protected]> * bump datafusion to fix first_value/last_value Signed-off-by: Ruihang Xia <[email protected]> * update sqlness result Signed-off-by: Ruihang Xia <[email protected]> * use retain instead Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
ScalarUDFandScalarFuncas commutative since they only depend on one point each timecount(*)last_value/first_valueChecklist
Refer to a related PR or issue link (optional)