feat: memtable filter push down #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should add some benchmark for this feature. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2539 +/- ##
===========================================
- Coverage 85.38% 85.01% -0.38%
===========================================
Files 737 737
Lines 117761 117916 +155
===========================================
- Hits 100553 100241 -312
- Misses 17208 17675 +467 |
I've run an informal test against this branch, it can improve by around 70% performance in scanning memtable. |
Cool. It would be beneficial for future improvements if we include a benchmark program in the repository. |
v0y4g3r
requested review from
evenyag and
waynexia
and removed request for
evenyag
evenyag
reviewed
Oct 9, 2023
v0y4g3r
force-pushed
the
feat/memtable-filter
branch
from
441bbc7 to
fe18dfb
Compare
evenyag
approved these changes
Oct 10, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: memtable support filter pushdown to prune primary keys * fix: switch to next time series when pk not selected * fix: allow predicate evaluation failure * fix: some clippy warnings * fix: panic when no primary key in schema * feat: cache decoded record batch for primary key * refactor: use arcswap instead of rwlock * fix: format toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR enables filter pushdown for memtable so that irrelavant time series can be skipped.
Checklist
Refer to a related PR or issue link (optional)