feat: enable tcp no_delay by default for internal services #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
fix/serve_with_tcpincoming
branch
from
41568b9 to
9e7a3e4
Compare
WenyXu
force-pushed
the
fix/serve_with_tcpincoming
branch
from
9e7a3e4 to
b9663f1
Compare
WenyXu
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2527 +/- ##
===========================================
- Coverage 85.28% 84.94% -0.34%
===========================================
Files 730 730
Lines 116093 116095 +2
===========================================
- Hits 99009 98618 -391
- Misses 17084 17477 +393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Enable
TCP_NODELAYfor internal services by default, enabled by default intonic::transport::server::Router::serve_with_shutdown. However,TcpListenerStream+TcpListenerdidn't.For small, sequential requests, Disable
TCP_NODELAYis slower ~100x than enabled (used inTcpIncoming).TL; DR. I'm tuning my program and copying some ideas from the greptimedb repo, which has become slower.
Above(Enable)
Below(Disable)
Checklist
Refer to a related PR or issue link (optional)