fix(mito): pruning for mito2 #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group size for each flush task.
evenyag
commented
Oct 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2525 +/- ##
===========================================
- Coverage 85.28% 84.96% -0.32%
===========================================
Files 730 733 +3
Lines 116093 117035 +942
===========================================
+ Hits 99009 99444 +435
- Misses 17084 17591 +507 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: pruning for mito2 * chore: refactor projection parameters; add some tests; customize row group size for each flush task. * chore: pass whole RegionFlushRequest --------- Co-authored-by: Lei, HUANG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements row group pruning for the new mito engine.
Previous implementation uses the schema of the region to find the index of a column, which is incorrect under the new SST format. Due to the restriction that the row group metadata only contains the min/max values of primary keys, not tags, the
ParquetReadercan only use the first tag in the primary key to prune row groups.Checklist
Refer to a related PR or issue link (optional)
fixes #2524