feat: improve object storage cache #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2522 +/- ##
===========================================
- Coverage 85.27% 84.99% -0.28%
===========================================
Files 729 732 +3
Lines 115960 116814 +854
===========================================
+ Hits 98887 99291 +404
- Misses 17073 17523 +450 |
waynexia
reviewed
Oct 7, 2023
evenyag
reviewed
Oct 7, 2023
Co-authored-by: Ruihang Xia <[email protected]>
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
evenyag
reviewed
Oct 7, 2023
waynexia
approved these changes
Oct 7, 2023
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
|
@evenyag Applied the suggestions, thank u. PTAL. |
evenyag
approved these changes
Oct 8, 2023
killme2008
force-pushed
the
feature/object-store-cache-improvements
branch
from
c7a5f33 to
30349a2
Compare
zhongzc
reviewed
Oct 8, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: refactor object storage cache with moka * chore: minor fixes * fix: concurrent issues and invalidate cache after write/delete * chore: minor changes * fix: cargo lock * refactor: rename * chore: change DEFAULT_OBJECT_STORE_CACHE_SIZE to 256Mib * fix: typo * chore: style * fix: toml format * chore: toml * fix: toml format * Update src/object-store/src/layers/lru_cache/read_cache.rs Co-authored-by: Ruihang Xia <[email protected]> * chore: update Cargo.toml Co-authored-by: Yingwen <[email protected]> * chore: update src/object-store/Cargo.toml Co-authored-by: Yingwen <[email protected]> * chore: refactor and apply suggestions * fix: typo * feat: adds back allow list for caching * chore: cr suggestion Co-authored-by: Yingwen <[email protected]> * chore: cr suggestion Co-authored-by: Yingwen <[email protected]> * refactor: wrap inner Accessor with Arc * chore: remove run_pending_task in read and write path * chore: the arc is unnecessary --------- Co-authored-by: Ruihang Xia <[email protected]> Co-authored-by: Yingwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Improve object storage local cache:
256 Mib.async_eviction_listenerin moka to remove the evicted files.Checklist
Refer to a related PR or issue link (optional)
Partial work of #2516