Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-create heartbeat stream ASAP #2499

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 26, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. set default connect timeout to 1000 ms
  2. re-create heartbeat stream ASAP

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2496

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2499 (ddb2943) into develop (230a302) will decrease coverage by 0.13%.
Report is 8 commits behind head on develop.
The diff coverage is 33.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2499      +/-   ##
===========================================
- Coverage    85.02%   84.90%   -0.13%     
===========================================
  Files          724      729       +5     
  Lines       115337   115964     +627     
===========================================
+ Hits         98071    98463     +392     
- Misses       17266    17501     +235     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/datanode.example.toml Show resolved Hide resolved
@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 27, 2023
Merged via the queue into GreptimeTeam:develop with commit 9282e59 Sep 27, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* chore: set default connect_timeout_millis to 1000

* fix: re-create heartbeat stream ASAP

* chore: apply suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants