fix: check for table scan before expanding #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2491 +/- ##
===========================================
- Coverage 84.98% 84.88% -0.11%
===========================================
Files 726 729 +3
Lines 115592 115862 +270
===========================================
+ Hits 98241 98353 +112
- Misses 17351 17509 +158 |
|
@waynexia There is a clippy warning. |
Signed-off-by: Ruihang Xia <[email protected]>
|
You have to update the sqlness result too. @waynexia |
Signed-off-by: Ruihang Xia <[email protected]>
zhongzc
reviewed
Sep 26, 2023
zhongzc
reviewed
Sep 26, 2023
2 tasks
Signed-off-by: Ruihang Xia <[email protected]>
zhongzc
approved these changes
Sep 26, 2023
Signed-off-by: Ruihang Xia <[email protected]>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: check for table scan before expanding Signed-off-by: Ruihang Xia <[email protected]> * change assert_ok to unwrap Signed-off-by: Ruihang Xia <[email protected]> * fix clippy warning Signed-off-by: Ruihang Xia <[email protected]> * update sqlness result Signed-off-by: Ruihang Xia <[email protected]> * don't skip dml Signed-off-by: Ruihang Xia <[email protected]> * uncomment ignored tests Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
DistPlanner should only modify "queries" that need to access remote data. LogicalPlan also contains some DDL/DML plan which should be ignored by our planner
Checklist
Refer to a related PR or issue link (optional)