-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support greatest function #2490
feat: support greatest function #2490
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2490 +/- ##
===========================================
+ Coverage 84.83% 84.90% +0.06%
===========================================
Files 726 730 +4
Lines 115028 116085 +1057
===========================================
+ Hits 97586 98558 +972
- Misses 17442 17527 +85 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, a little suggestion. Thank u very much.
@waynexia PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
@NiwakaDev Thank you for your contribution and patience. |
* feat: support greatest function * feat: make greatest take date_type as input * fix: move sqlness test into common/function/time.sql * fix: avoid using unwarp * fix: use downcast * refactor: simplify arrow cast
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds support
greatest(Date, Date)
like this:Will generate:
Checklist
Refer to a related PR or issue link (optional)
Related to #1536.
Resources
This PR is based on: