feat(mito): Add cache manager #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2488 +/- ##
===========================================
- Coverage 84.98% 84.61% -0.37%
===========================================
Files 724 727 +3
Lines 115298 115603 +305
===========================================
- Hits 97987 97822 -165
- Misses 17311 17781 +470 |
killme2008
reviewed
Sep 26, 2023
waynexia
reviewed
Sep 26, 2023
killme2008
approved these changes
Sep 26, 2023
waynexia
approved these changes
Sep 26, 2023
It takes effect. The default value is a non-zero value. |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: add cache manager * feat: add cache to reader builder * feat: add AsyncFileReaderCache * feat: Impl AsyncFileReaderCache * chore: move moka dep to workspace * feat: add moka cache to the manager * feat: implement parquet meta cache * test: test cache manager * feat: consider vec size * style: fix clippy * test: fix config api test * feat: divide cache * test: test disabling meta cache * test: fix config api test * feat: remove meta cache if file is purged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds a manager
CacheManagerto cache data for the mito engine. This is the first step to implement a cache component for the engine.It implements a cache layer
AsyncFileReaderCachefor parquet'sAsyncFileReadertrait so we can return our cached metadata toParquetRecordBatchStreamBuilder. TheAsyncFileReaderCachealso has local cached metadata. It is unused now but is useful when we implement row group readers that require buildingParquetRecordBatchStreamBuildermultiple times.Now the
CacheManageronly caches metadata of the parquet file. This might provide less improvement in performance. I'll start refactoring ourParquetReaderto support caching other data after this PR is merged.Checklist
Refer to a related PR or issue link (optional)