refactor: extract plugins crate
#2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2487 +/- ##
===========================================
- Coverage 85.36% 84.96% -0.40%
===========================================
Files 734 737 +3
Lines 117347 117390 +43
===========================================
- Hits 100169 99743 -426
- Misses 17178 17647 +469 |
paomian
reviewed
Oct 8, 2023
killme2008
reviewed
Oct 8, 2023
|
@killme2008 @MichaelScofield @paomian PTAL 😃 |
paomian
approved these changes
Oct 9, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: move frontend plugins fn * chore: move datanode plugins to fn * chore: add opt plugins * chore: add plugins to meta-srv * chore: setup meta plugins, wait for router extension * chore: try use configurator for grpc too * chore: minor fix fmt * chore: minor fix fmt * chore: add start meta_srv for hook * chore: merge develop * chore: minor fix * chore: replace Arc<Plugins> with PluginsRef * chore: fix header * chore: remove empty file * chore: modify comments * chore: remove PluginsRef type alias * chore: remove `OptPlugins`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly extracts
pluginscrate, which provides functions for initializing and starting plugins for frontend/datanode/meta-srv.Checklist
Refer to a related PR or issue link (optional)