Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add integration test for issue2437 #2481

Conversation

NiwakaDev
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR adds a integration test for issue2437. Very trivial.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Related to #2437 (comment)

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #2481 (6cb13cd) into develop (00272d5) will decrease coverage by 0.37%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2481      +/-   ##
===========================================
- Coverage    84.98%   84.62%   -0.37%     
===========================================
  Files          725      725              
  Lines       115465   115465              
===========================================
- Hits         98123    97707     -416     
- Misses       17342    17758     +416     

@NiwakaDev NiwakaDev force-pushed the chore/add_integration_test_for_issue2437 branch from 2780ff5 to 6cb13cd Compare September 24, 2023 23:25
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Sep 25, 2023
Merged via the queue into GreptimeTeam:develop with commit f9351e4 Sep 25, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants