Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:migrate select tests from DuckDB #2478

Closed
wants to merge 4 commits into from

Conversation

Gump9
Copy link
Contributor

@Gump9 Gump9 commented Sep 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

migrate select sqlness test from DuckDB

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1168

@Gump9 Gump9 changed the title feat:migrate slect tests from duckDB feat:migrate select tests from DuckDB Sep 24, 2023
@evenyag evenyag changed the base branch from develop to main December 28, 2023 03:58
@evenyag
Copy link
Contributor

evenyag commented Dec 28, 2023

Hi, we are going to switch to the main branch, as mentioned in #3025.

I have changed the base branch of this PR to main.

@tisonkun tisonkun marked this pull request as ready for review March 14, 2024 01:55
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (9282e59) to head (93f8e3f).
Report is 689 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
- Coverage   85.27%   85.07%   -0.20%     
==========================================
  Files         729      914     +185     
  Lines      115964   152792   +36828     
==========================================
+ Hits        98889   129995   +31106     
- Misses      17075    22797    +5722     

@tisonkun
Copy link
Collaborator

Close as stale. It seems our codebase evolves a lot and need a rebase for this patch.

@waynexia It seems our sqlness cases are coupled. The state in former SQL file will be conveyed to the latter ... How can we test new cases in a brand new environment?

@tisonkun tisonkun closed this Mar 15, 2024
@waynexia
Copy link
Member

Close as stale. It seems our codebase evolves a lot and need a rebase for this patch.

@waynexia It seems our sqlness cases are coupled. The state in former SQL file will be conveyed to the latter ... How can we test new cases in a brand new environment?

You can run the new cases only with -t param. But generally, a case should clean its state to avoid having side affect on others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants