refactor: remove SqlStatementExecutor #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2464 +/- ##
===========================================
- Coverage 84.83% 84.48% -0.36%
===========================================
Files 726 725 -1
Lines 114995 114977 -18
===========================================
- Hits 97551 97133 -418
- Misses 17444 17844 +400 |
WenyXu
approved these changes
Sep 21, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia [email protected]
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
SqlStatementExecutoris no longer neededChecklist
Refer to a related PR or issue link (optional)