Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make upload-to-s3 configurable(for now, it's false) #2456

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Sep 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

ci: make upload-to-s3 configurable(for now, it's false)

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2456 (f1c022d) into develop (23cc7d8) will decrease coverage by 0.38%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2456      +/-   ##
===========================================
- Coverage    84.81%   84.43%   -0.38%     
===========================================
  Files          727      727              
  Lines       114977   114977              
===========================================
- Hits         97517    97086     -431     
- Misses       17460    17891     +431     

@waynexia waynexia enabled auto-merge September 20, 2023 14:12
@waynexia waynexia added this pull request to the merge queue Sep 20, 2023
Merged via the queue into GreptimeTeam:develop with commit df08771 Sep 20, 2023
13 checks passed
@zyy17 zyy17 deleted the ci/make-upload-configurable branch October 10, 2023 01:38
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants