Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify table metadata cache invalidator #2449

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 19, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

unify table metadata cache invalidator

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the feat/unify-cache-invalidator branch from 9be6450 to 2c04293 Compare September 19, 2023 16:24
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2449 (f696916) into develop (339e12c) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 38.88%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #2449    +/-   ##
=========================================
  Coverage    77.55%   77.55%            
=========================================
  Files          717      716     -1     
  Lines       112479   112750   +271     
=========================================
+ Hits         87228    87440   +212     
- Misses       25251    25310    +59     

@fengjiachun
Copy link
Collaborator

@MichaelScofield PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 580d11b Sep 21, 2023
11 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: unify table metadata cache invalidator

* chore: apply from suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants