Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error after updating protos #2435

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The ColumnDef has a new field comment, we have to resolve the compile errors.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 marked this pull request as ready for review September 18, 2023 12:00
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2435 (73a0a9b) into develop (5566f34) will decrease coverage by 0.05%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2435      +/-   ##
===========================================
- Coverage    77.64%   77.59%   -0.05%     
===========================================
  Files          729      729              
  Lines       115106   115114       +8     
===========================================
- Hits         89369    89318      -51     
- Misses       25737    25796      +59     

@fengjiachun fengjiachun added this pull request to the merge queue Sep 18, 2023
Merged via the queue into GreptimeTeam:develop with commit 342cc0a Sep 18, 2023
18 of 19 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@killme2008 killme2008 deleted the feature/fix-integration-compile-error branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants