Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename coordination to require_lease_before_startup #2431

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

rename coordination to require_lease_before_startup

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2431 (80aa475) into develop (73af136) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is 12.50%.

❗ Current head 80aa475 differs from pull request most recent head 7acfb4e. Consider uploading reports for the commit 7acfb4e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2431      +/-   ##
===========================================
- Coverage    77.40%   77.40%   -0.01%     
===========================================
  Files          721      726       +5     
  Lines       113824   114155     +331     
===========================================
+ Hits         88109    88365     +256     
- Misses       25715    25790      +75     

src/datanode/src/datanode.rs Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft September 18, 2023 10:10
@WenyXu WenyXu force-pushed the refactor/rename-coordination branch from 66c7e5c to 97db57a Compare September 18, 2023 10:12
@WenyXu WenyXu marked this pull request as ready for review September 18, 2023 10:12
@WenyXu WenyXu force-pushed the refactor/rename-coordination branch from 97db57a to a2f91a9 Compare September 18, 2023 10:48
@WenyXu WenyXu force-pushed the refactor/rename-coordination branch from a2f91a9 to 80aa475 Compare September 18, 2023 10:50
@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 18, 2023
Merged via the queue into GreptimeTeam:develop with commit 43476e1 Sep 18, 2023
14 of 16 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants