refactor: remove source and location in snafu display
#2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
force-pushed
the
refactor/error
branch
from
c76038a to
abda073
Compare
shuiyisong
force-pushed
the
refactor/error
branch
from
abda073 to
f7f204e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2428 +/- ##
===========================================
- Coverage 84.81% 84.51% -0.31%
===========================================
Files 727 727
Lines 114977 114996 +19
===========================================
- Hits 97518 97187 -331
- Misses 17459 17809 +350 |
waynexia
approved these changes
Sep 20, 2023
Co-authored-by: fys <[email protected]>
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…am#2428) * refactor: remove source pt 1 * refactor: remove source pt 2 * refactor: remove source pt 3 * refactor: remove location pt 1 * refactor: remove location pt 2 * chore: remove rustc files * chore: fix error case * chore: fix test * chore: fix test * chore: fix cr issue Co-authored-by: fys <[email protected]> --------- Co-authored-by: fys <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly removes
sourceandlocationin snafu display so that clear info is returned to client.Checklist
Refer to a related PR or issue link (optional)
part of #1854