Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render comment in SHOW CREATE TABLE #2427

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: render comment in SHOW CREATE TABLE #2427

merged 3 commits into from
Sep 18, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Sep 18, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

render comment in SHOW CREATE TABLE clause

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2367

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #2427 (c8ba73f) into develop (b0c56a3) will decrease coverage by 0.06%.
The diff coverage is 63.63%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2427      +/-   ##
===========================================
- Coverage    77.45%   77.40%   -0.06%     
===========================================
  Files          726      726              
  Lines       114155   114207      +52     
===========================================
- Hits         88422    88399      -23     
- Misses       25733    25808      +75

fengjiachun
fengjiachun approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge September 18, 2023 10:47
@waynexia waynexia added this pull request to the merge queue Sep 18, 2023
Merged via the queue into GreptimeTeam:develop with commit fbbf397 Sep 18, 2023
11 checks passed
@waynexia waynexia deleted the fix-show-create-table-3 branch September 18, 2023 11:01
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@waynexia @paomian
fix: render comment in SHOW CREATE TABLE (GreptimeTeam#2427)
3503989 
* feat: add comment field to ColumnDef

Signed-off-by: Ruihang Xia <[email protected]>

* fix sqlness case

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynexia @fengjiachun @WenyXu