-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make scripts table work again #2420
feat: make scripts table work again #2420
Conversation
cc5fbf2
to
30fcc11
Compare
30fcc11
to
1579f08
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2420 +/- ##
===========================================
+ Coverage 77.52% 77.63% +0.10%
===========================================
Files 721 727 +6
Lines 113723 114386 +663
===========================================
+ Hits 88167 88801 +634
- Misses 25556 25585 +29 |
This kind of hook isn't viable, the region is opened in datanode while recompilation happened in frontend. After discussing with @killme2008 we think we need to add a "specific initialize" interface to frontend. Only initialized database (catalog/schema) are available in that instance. |
Co-authored-by: Ruihang Xia <[email protected]>
@MichaelScofield PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: make scripts table work again * chore: typo * fix: license header * Update src/table/src/metadata.rs Co-authored-by: Ruihang Xia <[email protected]> * chore: cr comments --------- Co-authored-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The final PR to make the scripts table work again.
Main changes:
scripts
table in thepublic
schema for every catalogscripts
table lazily only when inserting or executing scripts by HTTP APIs.scripts
table schema, removegmt_created
and setschema, name, engine
as primary key.todo:
Checklist
Refer to a related PR or issue link (optional)