Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing datanode id on keep lease #2415

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Sep 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title said.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #2415 (589557e) into develop (342a6d0) will decrease coverage by 0.09%.
The diff coverage is 11.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2415      +/-   ##
===========================================
- Coverage    77.60%   77.51%   -0.09%     
===========================================
  Files          718      718              
  Lines       113661   113654       -7     
===========================================
- Hits         88205    88101     -104     
- Misses       25456    25553      +97     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Sep 17, 2023
Merged via the queue into GreptimeTeam:develop with commit 542e863 Sep 17, 2023
13 checks passed
@fengjiachun fengjiachun deleted the fix/missing-datanode-id branch September 17, 2023 09:17
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants