feat: heartbeat request with header #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
requested review from
WenyXu,
fengys1996,
waynexia and
MichaelScofield
fengjiachun
force-pushed
the
feat/heartbeat-header
branch
from
816bee4 to
fb94c3e
Compare
WenyXu
approved these changes
Sep 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2412 +/- ##
===========================================
- Coverage 77.57% 77.55% -0.02%
===========================================
Files 718 718
Lines 113623 113661 +38
===========================================
+ Hits 88143 88154 +11
- Misses 25480 25507 +27 |
fengjiachun
force-pushed
the
feat/heartbeat-header
branch
2 times, most recently
from
7d1e36c to
2a81d11
Compare
fengjiachun
force-pushed
the
feat/heartbeat-header
branch
from
2a81d11 to
59823b4
Compare
evenyag
approved these changes
Sep 16, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: heartbeat request with header * chore: frontend send heartbeat with a longer interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
When sending heartbeat request, set header because metasrv requires this.
Checklist
Refer to a related PR or issue link (optional)