Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve more integration tests #2406

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: resolve more integration tests #2406

merged 2 commits into from
Sep 15, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

#2386 : 20/38

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fengjiachun
fengjiachun approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #2406 (315103c) into develop (43e3c94) will decrease coverage by 0.10%.
Report is 1 commits behind head on develop.
The diff coverage is 8.82%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2406      +/-   ##
===========================================
- Coverage    77.56%   77.46%   -0.10%     
===========================================
  Files          716      716              
  Lines       112955   113062     +107     
===========================================
- Hits         87610    87582      -28     
- Misses       25345    25480     +135

WenyXu
WenyXu approved these changes Sep 15, 2023
View reviewed changes
tests-integration/tests/http.rs Outdated Show resolved Hide resolved
killme2008
killme2008 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 15, 2023
Merged via the queue into GreptimeTeam:develop with commit 4b13c88 Sep 15, 2023
11 checks passed
@MichaelScofield MichaelScofield deleted the fix/resolve-integration-tests branch September 15, 2023 09:52
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@MichaelScofield @WenyXu @paomian
fix: resolve more integration tests (GreptimeTeam#2406)
f858ffe 
* fix: resolve more integration tests

* Update tests-integration/tests/http.rs

Co-authored-by: Weny Xu <[email protected]>

---------

Co-authored-by: Weny Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@killme2008 killme2008 killme2008 approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelScofield @killme2008 @fengjiachun @WenyXu