-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clap wrapper around sqlness #2400
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2400 +/- ##
===========================================
- Coverage 77.53% 77.46% -0.07%
===========================================
Files 717 717
Lines 113984 113984
===========================================
- Hits 88373 88299 -74
- Misses 25611 25685 +74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, appreciate it ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* feat: wrapped sqlness with clap to provide nice interface * fix: added spaces and changed -f flag to bool
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Added clap to the
sqlness
runner to improve the interface by providing help messages and allowing configurations.Please explain IN DETAIL what the changes are in this PR and why they are needed:
sqlness
can now accept arguments to be configured with when running tests. Below is the result of the help command after running:cargo sqlness -h
All arguments assume their default values when omitted from the command line. To use all arguments(or some):
Checklist
This PR references #2380