feat: reserve internal column #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhuZiyi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2396 +/- ##
===========================================
- Coverage 77.53% 77.46% -0.07%
===========================================
Files 717 716 -1
Lines 113962 113999 +37
===========================================
- Hits 88356 88305 -51
- Misses 25606 25694 +88 |
evenyag
reviewed
Sep 14, 2023
Signed-off-by: ZhuZiyi <[email protected]>
Signed-off-by: ZhuZiyi <[email protected]>
evenyag
reviewed
Sep 15, 2023
Signed-off-by: ZhuZiyi <[email protected]>
evenyag
approved these changes
Sep 15, 2023
waynexia
approved these changes
Sep 15, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: reserve internal column Signed-off-by: ZhuZiyi <[email protected]> * test: add function test Signed-off-by: ZhuZiyi <[email protected]> * fix: spell typos Signed-off-by: ZhuZiyi <[email protected]> * chore: resolve conversation Signed-off-by: ZhuZiyi <[email protected]> --------- Signed-off-by: ZhuZiyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The column name created by user cannot be the name of the reserved column.
Closes #2392
Checklist
Refer to a related PR or issue link (optional)
#2392