feat: type conversion between Values #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2394 +/- ##
===========================================
+ Coverage 77.63% 77.65% +0.01%
===========================================
Files 729 730 +1
Lines 115114 115885 +771
===========================================
+ Hits 89374 89985 +611
- Misses 25740 25900 +160 |
QuenKar
force-pushed
the
feat/cast-datatype
branch
from
36a0f40 to
461b593
Compare
|
should allow other types unconditionally convert to |
|
Can you provide a function that detects whether one type can be cast to another? |
QuenKar
force-pushed
the
feat/cast-datatype
branch
from
45dd867 to
18f1038
Compare
waynexia
reviewed
Sep 18, 2023
Co-authored-by: dennis zhuang <[email protected]>
QuenKar
force-pushed
the
feat/cast-datatype
branch
from
fd5f4e5 to
357c0fc
Compare
waynexia
approved these changes
Sep 18, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: add cast() in datatype trait. * feat: add cast for primitive type * feat: add unit test cases * test: add datetime/time cases. * refactor: time_type cast function. * chore: typos. * refactor code. * feat: add can_cast_type func. * chore: rename cast to try_cast * feat: impl cast_with_opt * chore: pub use cast_with_opt * chore: add timezone for test * Update src/common/time/src/date.rs Co-authored-by: dennis zhuang <[email protected]> * chore: duration type --------- Co-authored-by: dennis zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
main changes
try_cast()indatatypetrait.date/time/timestamp/datetimetypes.u8,u16,u32,u64,i8,i16,i32,i64,f32,f64cast.cast_with_optmethod which supports two mode which can be set withCastOptionfor casting type(for cast failed:strict modewill return error andnon-strictmode will return Null).Checklist
Refer to a related PR or issue link (optional)
Closes #2376