chore: decrease mutable write buffer limit #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2390 +/- ##
===========================================
- Coverage 77.52% 77.47% -0.05%
===========================================
Files 717 717
Lines 113961 113962 +1
===========================================
- Hits 88348 88294 -54
- Misses 25613 25668 +55 |
killme2008
approved these changes
Sep 14, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: set mutable limit to half of the global write buffer size * refactor: put handle_flush_finished after handle_flush_request * refactor: rename tests.rs to basic_test.rs * style: fmt code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR reduces the mutable write buffer limit to
global_write_buffer_size / 2. Otherwise, when we reach the mutable limit and trigger flush, it is easy to stall the engine as there is only1/8capacity left.Other minor refactors:
handle_flush_finished()tests.rsChecklist
Refer to a related PR or issue link (optional)