Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: querying temporary table #2387

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch fixes information_schema doesn't return anything.

It might also fix errors on numbers table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line of code can fix everything!

Looks very GM.

@killme2008 killme2008 added this pull request to the merge queue Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2387 (187dc74) into develop (f76aa27) will decrease coverage by 0.14%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2387      +/-   ##
===========================================
- Coverage    77.58%   77.45%   -0.14%     
===========================================
  Files          715      716       +1     
  Lines       113714   113735      +21     
===========================================
- Hits         88220    88088     -132     
- Misses       25494    25647     +153     

Merged via the queue into GreptimeTeam:develop with commit cc7eb3d Sep 13, 2023
11 checks passed
@waynexia waynexia deleted the fix-sqlness-2 branch September 14, 2023 02:57
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix information schema

Signed-off-by: Ruihang Xia <[email protected]>

* remove log

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants