Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make test-integration able to compile #2384

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix all the compile errors in crate "test-integration". Note that the test cases are not fixed, so I still comment out this crate in the workspace members.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2384 (f2ee5b6) into develop (f76aa27) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2384      +/-   ##
===========================================
- Coverage    77.58%   77.45%   -0.13%     
===========================================
  Files          715      716       +1     
  Lines       113714   113750      +36     
===========================================
- Hits         88220    88107     -113     
- Misses       25494    25643     +149     

@killme2008 killme2008 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into GreptimeTeam:develop with commit d08b05c Sep 13, 2023
11 checks passed
@MichaelScofield MichaelScofield deleted the fix/test-integration-compilation branch September 14, 2023 02:19
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: make test-integration able to compile

* chore: fmt toml

---------

Co-authored-by: WenyXu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants