Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate OpenDal to 0.39 #2383

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 13, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. migrate OpenDal to 0.39
  2. fix Opendal writes partial bytes without raising errors #2382

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the chore/opendal-latest branch from 9ea726b to 8d6dcbe Compare September 13, 2023 11:55
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2383 (471f2f4) into develop (1a72681) will decrease coverage by 0.09%.
Report is 7 commits behind head on develop.
The diff coverage is 32.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2383      +/-   ##
===========================================
- Coverage    77.55%   77.47%   -0.09%     
===========================================
  Files          716      715       -1     
  Lines       113722   113699      -23     
===========================================
- Hits         88202    88091     -111     
- Misses       25520    25608      +88     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 13, 2023
Merged via the queue into GreptimeTeam:develop with commit 93f3048 Sep 13, 2023
11 checks passed
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* chore: bump opendal to 7d552

* refactor: migrate OpenDal to 0.39

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opendal writes partial bytes without raising errors
3 participants