-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate OpenDal to 0.39 #2383
Merged
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:chore/opendal-latest
Sep 13, 2023
Merged
refactor: migrate OpenDal to 0.39 #2383
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:chore/opendal-latest
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
chore/opendal-latest
branch
from
September 13, 2023 11:55
9ea726b
to
8d6dcbe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2383 +/- ##
===========================================
- Coverage 77.55% 77.47% -0.09%
===========================================
Files 716 715 -1
Lines 113722 113699 -23
===========================================
- Hits 88202 88091 -111
- Misses 25520 25608 +88 |
killme2008
reviewed
Sep 13, 2023
killme2008
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MichaelScofield
approved these changes
Sep 13, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: bump opendal to 7d552 * refactor: migrate OpenDal to 0.39 * chore: apply suggestions from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)