Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the latest command line options for sqlness runner #2371

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • no fail fast for sqlness runner
  • change disable-region-failover to enable-region-failover
  • remove wal-dir

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia waynexia changed the title feat: use the latest command line options feat: use the latest command line options for sqlness runner Sep 13, 2023
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched the live yesterday. It works 🚀

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2371 (100764a) into develop (1a72681) will decrease coverage by 0.06%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2371      +/-   ##
===========================================
- Coverage    77.55%   77.50%   -0.06%     
===========================================
  Files          716      716              
  Lines       113722   113722              
===========================================
- Hits         88202    88138      -64     
- Misses       25520    25584      +64     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into GreptimeTeam:develop with commit 60bdf96 Sep 13, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eTeam#2371)

feat: use the latest command line options

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants