Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: atomic metadata #2366

Merged

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Sep 12, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Atomic creation of catalog and schema
  2. exist -> exists
  3. remove metadata_service

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2366 (757d48a) into develop (1a72681) will decrease coverage by 0.07%.
Report is 1 commits behind head on develop.
The diff coverage is 73.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2366      +/-   ##
===========================================
- Coverage    77.55%   77.49%   -0.07%     
===========================================
  Files          716      715       -1     
  Lines       113722   113674      -48     
===========================================
- Hits         88202    88093     -109     
- Misses       25520    25581      +61     

src/common/meta/src/key.rs Outdated Show resolved Hide resolved
@fengjiachun
Copy link
Collaborator Author

@MichaelScofield PTAL

@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 13, 2023
Merged via the queue into GreptimeTeam:develop with commit f76aa27 Sep 13, 2023
13 checks passed
@fengjiachun fengjiachun deleted the feat/atomic-metadata branch September 14, 2023 10:04
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: atomic creating metadata

* chore: exist exists

* chore: license header

* chore: weny never say that

* feat: add put_conditionally to kv_backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants