Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop region server #2356

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Make region server be able to be stopped.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@5f7d118). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 77efaa2 differs from pull request most recent head 0fc442b. Consider uploading reports for the commit 0fc442b to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             migrate-region-server    #2356   +/-   ##
========================================================
  Coverage                         ?   77.39%           
========================================================
  Files                            ?      724           
  Lines                            ?   114886           
  Branches                         ?        0           
========================================================
  Hits                             ?    88917           
  Misses                           ?    25969           
  Partials                         ?        0           

src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
src/datanode/src/region_server.rs Outdated Show resolved Hide resolved
src/mito2/src/engine.rs Show resolved Hide resolved
@fengjiachun
Copy link
Collaborator Author

@evenyag @waynexia PTAL

@fengjiachun fengjiachun force-pushed the feat/stop-region-server branch from 1cac9b0 to 0fc442b Compare September 12, 2023 09:02
@waynexia waynexia enabled auto-merge September 12, 2023 09:14
@waynexia waynexia added this pull request to the merge queue Sep 12, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit 82ceaac Sep 12, 2023
10 checks passed
@fengjiachun fengjiachun deleted the feat/stop-region-server branch September 12, 2023 09:31
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: stop region server

* fix: close region first
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: stop region server

* fix: close region first
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: stop region server

* fix: close region first
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
* feat: stop region server

* fix: close region first
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: stop region server

* fix: close region first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants