feat: implement truncate region for mito2 #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2335 +/- ##
===========================================
+ Coverage 77.53% 77.56% +0.03%
===========================================
Files 717 718 +1
Lines 113962 113553 -409
===========================================
- Hits 88356 88076 -280
+ Misses 25606 25477 -129 |
evenyag
reviewed
Sep 6, 2023
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
4 times, most recently
from
7144883 to
b5113ef
Compare
waynexia
reviewed
Sep 12, 2023
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
from
dc7820a to
3ace46e
Compare
waynexia
force-pushed
the
migrate-region-server
branch
from
50cea29 to
f1f7824
Compare
evenyag
reviewed
Sep 12, 2023
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
from
673e150 to
af959e0
Compare
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
from
4d43638 to
4aa297a
Compare
evenyag
reviewed
Sep 14, 2023
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
from
5005d99 to
ee38e98
Compare
evenyag
approved these changes
Sep 15, 2023
killme2008
approved these changes
Sep 15, 2023
Co-authored-by: dennis zhuang <[email protected]>
Co-authored-by: dennis zhuang <[email protected]>
Co-authored-by: dennis zhuang <[email protected]>
DevilExileSu
force-pushed
the
mito2/turncate_region
branch
from
d59da8e to
98c25f7
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement truncate region for mito2. * chore: add license header and fix typos * Update src/mito2/src/worker/handle_truncate.rs Co-authored-by: Yingwen <[email protected]> * cr * chore: consider the flush task being executed before truncating the region. * test * feat: check flush and compaction tasks * chore: remove useless changes * Update src/mito2/src/manifest/action.rs Co-authored-by: Yingwen <[email protected]> * Update src/mito2/src/worker/handle_flush.rs Co-authored-by: Yingwen <[email protected]> * chore: CR, consider sequence number * test: use EventListener to test the flush task during truncate * fix: fix listener error * Update src/mito2/src/engine/truncate_test.rs Co-authored-by: Yingwen <[email protected]> * chore: cr * fix: remove set None * Update src/mito2/src/region/version.rs Co-authored-by: dennis zhuang <[email protected]> * Update src/mito2/src/worker/handle_flush.rs Co-authored-by: dennis zhuang <[email protected]> * Update src/mito2/src/worker/handle_truncate.rs Co-authored-by: dennis zhuang <[email protected]> * doc: add some doc for FlushTruncateListener and RegionTruncate --------- Co-authored-by: Yingwen <[email protected]> Co-authored-by: dennis zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement truncate region for mito2.
Checklist
Refer to a related PR or issue link (optional)