Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Impl write buffer manager for mito2 #2309

Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Sep 3, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR ports the WriteBufferManager from the old mito engine to mito2.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review September 3, 2023 07:11
src/mito2/src/flush.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@2fec725). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c526417 differs from pull request most recent head cd2dde1. Consider uploading reports for the commit cd2dde1 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             migrate-region-server    #2309   +/-   ##
========================================================
  Coverage                         ?   78.82%           
========================================================
  Files                            ?      717           
  Lines                            ?   116582           
  Branches                         ?        0           
========================================================
  Hits                             ?    91900           
  Misses                           ?    24682           
  Partials                         ?        0           

@evenyag evenyag requested a review from v0y4g3r September 3, 2023 07:47
src/mito2/src/flush.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Sep 3, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit f7a1880 Sep 3, 2023
@evenyag evenyag deleted the feat/mito2-write-buffer branch September 3, 2023 08:45
@evenyag evenyag self-assigned this Sep 4, 2023
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: add write buffer manager to builder

* feat: impl WriteBufferManager

* feat: impl MemtableVersion::mutable_usage

* chore: Address CR comments

Co-authored-by: JeremyHi <[email protected]>

* refactor: rename mutable_limitation to mutable_limit

---------

Co-authored-by: JeremyHi <[email protected]>
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: add write buffer manager to builder

* feat: impl WriteBufferManager

* feat: impl MemtableVersion::mutable_usage

* chore: Address CR comments

Co-authored-by: JeremyHi <[email protected]>

* refactor: rename mutable_limitation to mutable_limit

---------

Co-authored-by: JeremyHi <[email protected]>
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* feat: add write buffer manager to builder

* feat: impl WriteBufferManager

* feat: impl MemtableVersion::mutable_usage

* chore: Address CR comments

Co-authored-by: JeremyHi <[email protected]>

* refactor: rename mutable_limitation to mutable_limit

---------

Co-authored-by: JeremyHi <[email protected]>
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
* feat: add write buffer manager to builder

* feat: impl WriteBufferManager

* feat: impl MemtableVersion::mutable_usage

* chore: Address CR comments

Co-authored-by: JeremyHi <[email protected]>

* refactor: rename mutable_limitation to mutable_limit

---------

Co-authored-by: JeremyHi <[email protected]>
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: add write buffer manager to builder

* feat: impl WriteBufferManager

* feat: impl MemtableVersion::mutable_usage

* chore: Address CR comments

Co-authored-by: JeremyHi <[email protected]>

* refactor: rename mutable_limitation to mutable_limit

---------

Co-authored-by: JeremyHi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants