-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Impl write buffer manager for mito2 #2309
feat: Impl write buffer manager for mito2 #2309
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2309 +/- ##
========================================================
Coverage ? 78.82%
========================================================
Files ? 717
Lines ? 116582
Branches ? 0
========================================================
Hits ? 91900
Misses ? 24682
Partials ? 0 |
Co-authored-by: JeremyHi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add write buffer manager to builder * feat: impl WriteBufferManager * feat: impl MemtableVersion::mutable_usage * chore: Address CR comments Co-authored-by: JeremyHi <[email protected]> * refactor: rename mutable_limitation to mutable_limit --------- Co-authored-by: JeremyHi <[email protected]>
* feat: add write buffer manager to builder * feat: impl WriteBufferManager * feat: impl MemtableVersion::mutable_usage * chore: Address CR comments Co-authored-by: JeremyHi <[email protected]> * refactor: rename mutable_limitation to mutable_limit --------- Co-authored-by: JeremyHi <[email protected]>
* feat: add write buffer manager to builder * feat: impl WriteBufferManager * feat: impl MemtableVersion::mutable_usage * chore: Address CR comments Co-authored-by: JeremyHi <[email protected]> * refactor: rename mutable_limitation to mutable_limit --------- Co-authored-by: JeremyHi <[email protected]>
* feat: add write buffer manager to builder * feat: impl WriteBufferManager * feat: impl MemtableVersion::mutable_usage * chore: Address CR comments Co-authored-by: JeremyHi <[email protected]> * refactor: rename mutable_limitation to mutable_limit --------- Co-authored-by: JeremyHi <[email protected]>
* feat: add write buffer manager to builder * feat: impl WriteBufferManager * feat: impl MemtableVersion::mutable_usage * chore: Address CR comments Co-authored-by: JeremyHi <[email protected]> * refactor: rename mutable_limitation to mutable_limit --------- Co-authored-by: JeremyHi <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR ports the
WriteBufferManager
from the old mito engine to mito2.Checklist
Refer to a related PR or issue link (optional)