feat: implement storage for OTLP histogram #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2282 +/- ##
===========================================
- Coverage 84.88% 84.60% -0.29%
===========================================
Files 725 725
Lines 115186 115421 +235
===========================================
- Hits 97780 97648 -132
- Misses 17406 17773 +367 |
yuanbohan
approved these changes
Aug 30, 2023
fengjiachun
reviewed
Sep 19, 2023
sunng87
force-pushed
the
feature/otlp-histogram-2
branch
from
46ccf4d to
7f1475a
Compare
Also updated row writer for owned keys
sunng87
force-pushed
the
feature/otlp-histogram-2
branch
from
1910ea0 to
9010120
Compare
|
Updated. PTAL @yuanbohan @fengjiachun @waynexia |
sunng87
force-pushed
the
feature/otlp-histogram-2
branch
from
6e16e83 to
c609f33
Compare
yuanbohan
approved these changes
Sep 22, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement new histogram data model * feat: use prometheus table format for histogram * refactor: remove duplicated code * fix: histogram tag column * fix: use accumulated count in buckets * refactor: using row based protocol for otlp WIP * refactor: use row based writer for otlp. Also updated row writer for owned keys * refactor: use row writers for otlp * test: add integration tests for histogram * refactor: change le column name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch adds OTLP histogram data type support, which was left blank in our initial release.
The implementation has been following Prometheus histogram table format:
%metric%_buckettable includingletag that stores bucket upper limit, andgreptime_valuefor bucket count%metric%_sumtable storing sum of samples%metric%_counttable storing count of samples.By its Prometheus compatibility, we hope to be able to use prometheus quantile functions on this table.
Checklist
Refer to a related PR or issue link (optional)