Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip procedure if target route is not found #2277

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 29, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

skip procedure if the target route is not found

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2277 (1c76ebc) into develop (68600a2) will decrease coverage by 0.44%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2277      +/-   ##
===========================================
- Coverage    85.21%   84.77%   -0.44%     
===========================================
  Files          715      715              
  Lines       117383   117456      +73     
===========================================
- Hits        100025    99579     -446     
- Misses       17358    17877     +519     

@WenyXu
Copy link
Member Author

WenyXu commented Aug 30, 2023

@MichaelScofield @fengjiachun PTAL

@WenyXu WenyXu force-pushed the fix/skip-procedure-if-failed-region-not-found branch from c576021 to 1c76ebc Compare August 30, 2023 05:53
@MichaelScofield MichaelScofield added this pull request to the merge queue Aug 30, 2023
Merged via the queue into GreptimeTeam:develop with commit 8e9f2ff Aug 30, 2023
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: skip procedure if target route is not found

* chore: apply suggestions from CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants