feat(mito): Support deleting rows in mito2 #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2275 +/- ##
===========================================
- Coverage 85.33% 84.97% -0.37%
===========================================
Files 712 712
Lines 116983 117265 +282
===========================================
- Hits 99831 99649 -182
- Misses 17152 17616 +464 |
waynexia
approved these changes
Sep 1, 2023
40 tasks
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: check delete request * test: test delete and overwrite
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: check delete request * test: test delete and overwrite
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: check delete request * test: test delete and overwrite
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
* feat: check delete request * test: test delete and overwrite
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: check delete request * test: test delete and overwrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR supports deleting rows by primary key and time index in mito2.
It also adds tests for deleting and overwriting rows.
Checklist
Refer to a related PR or issue link (optional)