Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use RegionId region number instead #2273

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

use RegionId region number instead

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the fix/update-metadata-region-number branch 2 times, most recently from 16a5fe5 to 38c9cae Compare August 28, 2023 12:58
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2273 (1a96834) into develop (ef75e8f) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2273      +/-   ##
===========================================
- Coverage    85.33%   84.92%   -0.42%     
===========================================
  Files          712      712              
  Lines       116983   116983              
===========================================
- Hits         99831    99347     -484     
- Misses       17152    17636     +484     

@WenyXu WenyXu force-pushed the fix/update-metadata-region-number branch from 38c9cae to d7999b7 Compare August 28, 2023 14:04
@WenyXu WenyXu force-pushed the fix/update-metadata-region-number branch from d7999b7 to 1a96834 Compare August 28, 2023 14:10
@MichaelScofield MichaelScofield added this pull request to the merge queue Aug 29, 2023
Merged via the queue into GreptimeTeam:develop with commit 22dea02 Aug 29, 2023
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants