Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set default metasrv procedure retry times to 12 #2242

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Set default metasrv procedure retry times to 12

Delay(s) Time Retry Delay(s) Acc Delay(s) Procedure(s) Start(s) End(s) Start(m) End(m)
0.5 1 0.5 1 30 1 31 0.0 0.5
2 1 1.5 60 1.5 61.5 0.0 1.0
3 2 3.5 90 3.5 93.5 0.1 1.6
4 4 7.5 120 7.5 127.5 0.1 2.1
5 8 15.5 150 15.5 165.5 0.3 2.8
6 16 31.5 180 31.5 211.5 0.5 3.5
7 32 63.5 210 63.5 273.5 1.1 4.6
8 64 127.5 240 127.5 367.5 2.1 6.1
9 128 255.5 270 255.5 525.5 4.3 8.8
10 256 511.5 300 511.5 811.5 8.5 13.5
11 512 1023.5 330 1023.5 1353.5 17.1 22.6
12 1024 2047.5 360 2047.5 2407.5 34.1 40.1

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu marked this pull request as draft August 24, 2023 07:23
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2242 (a09b70c) into develop (a7e0e23) will decrease coverage by 0.37%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2242      +/-   ##
===========================================
- Coverage    85.00%   84.64%   -0.37%     
===========================================
  Files          704      706       +2     
  Lines       115202   115557     +355     
===========================================
- Hits         97929    97809     -120     
- Misses       17273    17748     +475     

@WenyXu WenyXu force-pushed the chore/meta-procedure-retry-times branch from 94961e8 to 5f56aaa Compare August 24, 2023 07:27
@WenyXu WenyXu changed the title refactor: set default metasrv procedure retry times to 10 refactor: set default metasrv procedure retry times to 8 and delay to 5s Aug 24, 2023
@WenyXu WenyXu requested a review from evenyag August 24, 2023 07:28
@WenyXu WenyXu marked this pull request as ready for review August 24, 2023 07:28
@WenyXu WenyXu force-pushed the chore/meta-procedure-retry-times branch from 5f56aaa to f12e02c Compare August 24, 2023 07:32
@WenyXu WenyXu marked this pull request as draft August 24, 2023 07:45
@MichaelScofield
Copy link
Collaborator

Suggestion: add comments about the consequence of the retry strategy. For example, max time a procedure can last; retry interval etc.

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the chore/meta-procedure-retry-times branch from f12e02c to a09b70c Compare August 24, 2023 09:24
@WenyXu WenyXu marked this pull request as ready for review August 24, 2023 09:25
@WenyXu WenyXu changed the title refactor: set default metasrv procedure retry times to 8 and delay to 5s refactor: set default metasrv procedure retry times to 12 Aug 24, 2023
@evenyag evenyag added this pull request to the merge queue Aug 26, 2023
Merged via the queue into GreptimeTeam:develop with commit c56f5e3 Aug 26, 2023
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants