Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use table id instead of table ident #2233

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

use table id instead of table ident

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2233 (6f727c5) into develop (af95e46) will decrease coverage by 0.42%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           develop    #2233      +/-   ##
===========================================
- Coverage    84.94%   84.52%   -0.42%     
===========================================
  Files          703      703              
  Lines       114692   114702      +10     
===========================================
- Hits         97420    96956     -464     
- Misses       17272    17746     +474     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@waynexia waynexia added this pull request to the merge queue Aug 23, 2023
Merged via the queue into GreptimeTeam:develop with commit beb92ba Aug 23, 2023
@WenyXu WenyXu added the O-chaos Found by chaos tests label Sep 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants