feat(mito): Skeleton for scanning a region #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
evenyag
force-pushed
the
feat/mito2-handle-query
branch
2 times, most recently
from
2559f0a to
2a8cada
Compare
evenyag
force-pushed
the
feat/mito2-handle-query
branch
from
2a8cada to
6354cfd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2230 +/- ##
===========================================
- Coverage 85.22% 84.85% -0.38%
===========================================
Files 705 709 +4
Lines 115706 116304 +598
===========================================
+ Hits 98613 98687 +74
- Misses 17093 17617 +524 |
2 tasks
waynexia
reviewed
Aug 25, 2023
waynexia
reviewed
Aug 25, 2023
waynexia
reviewed
Aug 25, 2023
waynexia
approved these changes
Aug 25, 2023
Co-authored-by: Lei, HUANG <[email protected]>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: define stream builder * feat: scan region wip * feat: create SeqScan in ScanRegion * feat: scanner * feat: engine handles scan request * feat: map projection index to column id * feat: Impl record batch stream * refactor: change BatchConverter to ProjectionMapper * feat: add column_ids to mapper * feat: implement SeqScan::build() * chore: fix typo * docs: add mermaid for ScanRegion * style: fix clippy * test: fix record batch test * fix: update sequence and entry id * test: test query * feat: address CR comment * chore: address CR comments * chore: Update src/mito2/src/read/scan_region.rs Co-authored-by: Lei, HUANG <[email protected]> --------- Co-authored-by: Lei, HUANG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a skeleton for scanning a mito2 region. The mito engine creates a
ScanRegionto handle aScanRequest.A
ScanRegioncollects SSTs and memtables to scan without actually reading them. It creates aScannerto actually scan these targets inScanner::scan(). It may use different scan modes for different scan requests so theScanneris an enum. Now we only implement a sequential scan modeSeqScan.classDiagram class ScanRegion { -VersionRef version -ScanRequest request ~scanner() Scanner ~seq_scan() SeqScan } class Scanner { <<enumeration>> SeqScan +scan() SendableRecordBatchStream } class SeqScan { -ProjectionMapper mapper -Option~TimeRange~ time_range -Option~Predicate~ predicate -Vec~MemtableRef~ memtables -Vec~FileHandle~ files +build() SendableRecordBatchStream } class ProjectionMapper { ~output_schema() SchemaRef ~convert(Batch) RecordBatch } ScanRegion -- Scanner ScanRegion o-- ScanRequest Scanner o-- SeqScan Scanner -- SendableRecordBatchStream SeqScan o-- ProjectionMapper SeqScan -- SendableRecordBatchStreamChecklist
Refer to a related PR or issue link (optional)