-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): Skeleton for scanning a region #2230
Merged
v0y4g3r
merged 20 commits into
GreptimeTeam:develop
from
evenyag:feat/mito2-handle-query
Aug 28, 2023
Merged
feat(mito): Skeleton for scanning a region #2230
v0y4g3r
merged 20 commits into
GreptimeTeam:develop
from
evenyag:feat/mito2-handle-query
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
evenyag
force-pushed
the
feat/mito2-handle-query
branch
2 times, most recently
from
August 24, 2023 03:45
2559f0a
to
2a8cada
Compare
evenyag
force-pushed
the
feat/mito2-handle-query
branch
from
August 24, 2023 04:00
2a8cada
to
6354cfd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2230 +/- ##
===========================================
- Coverage 85.22% 84.85% -0.38%
===========================================
Files 705 709 +4
Lines 115706 116304 +598
===========================================
+ Hits 98613 98687 +74
- Misses 17093 17617 +524 |
2 tasks
waynexia
reviewed
Aug 25, 2023
waynexia
reviewed
Aug 25, 2023
waynexia
reviewed
Aug 25, 2023
waynexia
approved these changes
Aug 25, 2023
v0y4g3r
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
Co-authored-by: Lei, HUANG <[email protected]>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: define stream builder * feat: scan region wip * feat: create SeqScan in ScanRegion * feat: scanner * feat: engine handles scan request * feat: map projection index to column id * feat: Impl record batch stream * refactor: change BatchConverter to ProjectionMapper * feat: add column_ids to mapper * feat: implement SeqScan::build() * chore: fix typo * docs: add mermaid for ScanRegion * style: fix clippy * test: fix record batch test * fix: update sequence and entry id * test: test query * feat: address CR comment * chore: address CR comments * chore: Update src/mito2/src/read/scan_region.rs Co-authored-by: Lei, HUANG <[email protected]> --------- Co-authored-by: Lei, HUANG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a skeleton for scanning a mito2 region. The mito engine creates a
ScanRegion
to handle aScanRequest
.A
ScanRegion
collects SSTs and memtables to scan without actually reading them. It creates aScanner
to actually scan these targets inScanner::scan()
. It may use different scan modes for different scan requests so theScanner
is an enum. Now we only implement a sequential scan modeSeqScan
.Checklist
Refer to a related PR or issue link (optional)