feat(mito): Support handling RegionWriteRequest #2218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
#2160 breaks implementation of
write_region()
. This PR support writing a region again.It reuses the old
WriteRequest
as it is more friendly to implementing write than the plainRegionWriteRequest
. TheRegionTask
now holds aRequestBody
and we convertRegionWriteRequest
toWriteRequest
before sending it to the worker. As a result, we can do some validation outside of the worker.This PR also fixes all engine tests.
Checklist
Refer to a related PR or issue link (optional)